chore(deps): remove patch-package and related configuration #2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignited apps ([pre v10](https://github.com/infinitered/ignite/tree/v9.10.1/boilerplate/patches)) used to ship with yarn-only and a few patches that needed to be applied in the early days of react-native. Now, we offer users `yarn`, `npm`, `bun`, and `pnpm` as options for an ignited app. yarn berry, bun, and pnpm all have their own patching system. Because a newly ignited app no longer needs any patches, we can remove this legacy configuration and package script references.
e876dc3 to
99244b0
Compare
frankcalise
approved these changes
May 16, 2025
Comment on lines
+120
to
+121
| - `yarn@3` - use [`yarn patch` tool](https://v3.yarnpkg.com/features/protocols#patch). | ||
| - `yarn@4` - use [`yarn patch` tool](https://yarnpkg.com/features/patching). |
Contributor
There was a problem hiding this comment.
you can still use patch package with these versions as well, couldn't you?
Member
Author
There was a problem hiding this comment.
Actually no (but maybe yes with a bunch more configuration)... which is one of the main reasons I still use yarn 1, even though it's slow. yarn berry changed how the postinstall script runs so it's not nearly as reliable anymore. yarnpkg/yarn#5476
Collaborator
|
🎉 This PR is included in version 10.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ignited apps (pre v10) used to ship with yarn-only and a few patches that needed to be applied to get the dependencies working.
Now, we offer users
yarn,npm,bun, andpnpmas options for an ignited app.yarn berry, bun, and pnpm all have their own patching system. Because a newly ignited app no longer needs any patches, we can remove this legacy configuration and package script references.
slack conversation
Checklist
README.mdand other relevant documentation has been updated with my changes