chore(logbox): Remove LogBox.ignoreLogs() as it no longer works #2956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comit removes `LogBox.ignoreLogs([])` from the ignite boilerplate as it no longer works. https://reactnative.dev/blog/2023/01/12/version-071#restoring-proptypes > As part of this change, we are also removing the console filtering from LogBox.ignoreLog. This means logs that you have previously filtered with Logbox.ignoreLog will start appearing again in the console when you upgrade. > > This is expected, because it allows logs such as deprecation warnings to be found and fixed. You can see the commit that did this here: facebook/react-native@fa2842d
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-ineffective LogBox.ignoreLogs() utility from the Ignite boilerplate, cleaning up unused code introduced for React Native 0.71 deprecation filtering.
- Deleted the
ignoreWarnings.tsutility file that calledLogBox.ignoreLogs() - Removed its import from
app.tsx
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| boilerplate/app/utils/ignoreWarnings.ts | Deleted deprecated LogBox ignore-logs utility |
| boilerplate/app/app.tsx | Removed import of the deleted ignoreWarnings module |
mazenchami
approved these changes
May 21, 2025
As far as I understand it, it isn't possible to filter logbox warnings anymore. |
|
🎉 This PR is included in version 10.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This comit removes
LogBox.ignoreLogs([])from the ignite boilerplate as it was crippled in react-native 0.71.https://reactnative.dev/blog/2023/01/12/version-071#restoring-proptypes
You can see the commit that did this here: facebook/react-native@fa2842d
Checklist