这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(cli): correct mobx removal when using prompts #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

fix(cli): correct mobx removal when using prompts #2949

merged 2 commits into from
May 20, 2025

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented May 14, 2025

Description

  • Closes Remove MobX option doesn't remove all mobx code #2947
  • This actually worked if you use the CLI switches, ie: --state none but failed during the prompts
    • useDefault is only meant to apply the default value if --yes is applied, so even though we skipped the prompt for removing the demo application (as intended, because the user wanted to remove MST), we didn't later remove the code, only markup
    • Since our tests utilize the CLI, this fell through the cracks, need to better emulate following prompts at some point would be a good follow up to this.

Checklist

  • I have manually tested this, including by generating a new app locally (see docs).

@frankcalise frankcalise requested a review from robinheinze May 14, 2025 22:25
robinheinze
robinheinze approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@robinheinze robinheinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, Frank! Thanks for jumping on this :)

@objectiveSee
Copy link
Contributor

objectiveSee commented May 15, 2025

Thanks for fixing this! Well done everyone!

@markrickert
Copy link
Member

markrickert commented May 16, 2025

Just verified that this fix works as expected and it does!

cd ~/Documents
./ignite/bin/ignite new Foo --overwrite
cng
no git
bun package manager
install deps
expo-router: yes
new arch: yes
mst: no

Left screenshot is master and right screenshot is this branch with these exact same prompts.

Screenshot 2025-05-16 at 8 55 31 AM

@frankcalise frankcalise merged commit 73e9809 into master May 20, 2025
3 checks passed
@frankcalise frankcalise deleted the frankcalise/fix-2947 branch May 20, 2025 15:42
infinitered-circleci pushed a commit that referenced this pull request May 20, 2025
@semantic-release-bot
chore(release): 10.4.1 [skip ci]
df7c9c1 
## [10.4.1](v10.4.0...v10.4.1) (2025-05-20)

### Bug Fixes

* **cli:** correct mobx removal when using prompts ([#2949](#2949) by [@frankcalise](https://github.com/frankcalise)) ([73e9809](73e9809))
* **docs:** updated the doc for i18n translate to reflect proper usage of the translation keys ([#2924](#2924)) [skip ci] ([7bb8c5c](7bb8c5c))
* **Header:** change Header's pointerEvents="none" from a prop to a style ([#2933](#2933)) [skip ci] ([a0d305f](a0d305f))
* **tests:** fix i18n tests failing because of a rogue grep and regex not understanding comments ([#2950](#2950)) [skip ci] ([17dd1a4](17dd1a4)), closes [#2924](#2924)
@infinitered-circleci
Copy link
Collaborator

infinitered-circleci commented May 20, 2025

🎉 This PR is included in version 10.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markrickert markrickert mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markrickert markrickert markrickert approved these changes

@robinheinze robinheinze robinheinze approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove MobX option doesn't remove all mobx code

6 participants

@frankcalise @objectiveSee @markrickert @infinitered-circleci @robinheinze