expo53: configuration, dependency, linting, and maestro fixes #2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making these changes showed a bunch of linting errors and typescript compiler issues, some of which were valid.
Expo 53 - new architecture doesn’t show dev server picker Expo 53 - no new architecture shows dev server this fixes the issue by conditionally waiting to see if that text is on the screen and if so, tap through the expo dev client screens
There was a problem hiding this comment.
Pull Request Overview
This PR aims to align the project with Expo SDK 53 changes by updating TypeScript configuration, correcting type mismatches, and standardizing dependency versions and linting configurations. Key changes include:
- Updates to tsconfig settings to match Expo SDK 53 (moduleResolution, module, customConditions).
- Fixes to type declarations and imports (e.g. swapping ViewStyle/TextStyle types, type assertions updates).
- Maestro test flow simplifications and dependency updates in package.json and ESLint configurations.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/snapshots/markup.test.ts.snap | Snapshot string formatting updates removing unnecessary escapes. |
| src/commands/new.ts | Renamed utility function from useDefault to getDefault for clarity. |
| src/commands/generate/splash-screen.ts | Added an ESLint disable comment for destructured variable const preference. |
| package.json & boilerplate/* | Updated dependency versions and TS config to reflect Expo SDK 53. |
| boilerplate/app/screens/DemoShowroomScreen/DemoShowroomScreen.tsx | Improved type assertions and cleanup in asynchronous logic. |
| boilerplate/app/devtools/ReactotronConfig.ts | Added a temporary @ts-ignore with clarification that it’s for debugging. |
| boilerplate/app/components/Toggle/* | Adjusted style type definitions to unify component style expectations. |
| boilerplate/.maestro/* | Simplified Maestro flows and removed outdated subflows. |
| .eslintrc.js & .eslintignore | Inherited ESLint config from boilerplate and ignored snapshots/files. |
markrickert
commented
May 13, 2025
| @@ -180,7 +180,7 @@ module.exports = { | |||
|
|
|||
| const yname = boolFlag(options.y) || boolFlag(options.yes) | |||
| const noTimeout = options.noTimeout ?? false | |||
| const useDefault = (option: unknown) => yname && option === undefined | |||
There was a problem hiding this comment.
The new linter config was complaining about "use" being a react-only keyword so i changed it to "get"
markrickert
commented
May 13, 2025
| @@ -166,7 +168,11 @@ export const DemoShowroomScreen: FC<DemoTabScreenProps<"DemoShowroom">> = | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
| return () => timeout.current && clearTimeout(timeout.current) | |||
There was a problem hiding this comment.
the linter was complaining about this possibly returning null 🤦
fpena
approved these changes
May 14, 2025
|
@markrickert in the future let's make sure we merge branches like this with feat/fix for semver which would have gone through the auto release process the typical commit would look like
see https://docs.infinite.red/ignite-cli/contributing/Releasing-Ignite/#a-note-about-semver for more info |
markrickert
added a commit
that referenced
this pull request
May 21, 2025
* chore(typescript): update moduleResolution and module properties Making these changes showed a bunch of linting errors and typescript compiler issues, some of which were valid. * fix(tests): allow metro to work regardless of expo-dev-client Expo 53 - new architecture doesn’t show dev server picker Expo 53 - no new architecture shows dev server this fixes the issue by conditionally waiting to see if that text is on the screen and if so, tap through the expo dev client screens * chore(deps): update dependencies * chore(linter): move the eslint config to a js file and inherit from the boilerplate
markrickert
added a commit
that referenced
this pull request
May 22, 2025
* chore(typescript): update moduleResolution and module properties Making these changes showed a bunch of linting errors and typescript compiler issues, some of which were valid. * fix(tests): allow metro to work regardless of expo-dev-client Expo 53 - new architecture doesn’t show dev server picker Expo 53 - no new architecture shows dev server this fixes the issue by conditionally waiting to see if that text is on the screen and if so, tap through the expo dev client screens * chore(deps): update dependencies * chore(linter): move the eslint config to a js file and inherit from the boilerplate
markrickert
added a commit
that referenced
this pull request
May 28, 2025
* chore(typescript): update moduleResolution and module properties Making these changes showed a bunch of linting errors and typescript compiler issues, some of which were valid. * fix(tests): allow metro to work regardless of expo-dev-client Expo 53 - new architecture doesn’t show dev server picker Expo 53 - no new architecture shows dev server this fixes the issue by conditionally waiting to see if that text is on the screen and if so, tap through the expo dev client screens * chore(deps): update dependencies * chore(linter): move the eslint config to a js file and inherit from the boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes a few changes to @fpena's expo 53 branch in #2938:
moduleResolutionchanged from'nodetobundlermodulechanged fromes2015topreserve"customConditions": ["react-native"]to the compiler options.yarn compilecommand previously. Mostly just accidentally substitutingViewStyleforTextStylein the type declarations.expo/non-expo + newArch/oldArch. ... simplifies the number of files/scripts needed, and reduces the amount of logic needed to bypass both the dev server picker screen and the dev menu bottom sheet from expo that shows up in expo dev builds in the oldArch.npx expo install --fixtold me to update including the@types/reactandexpo-routerdeps.Checklist
README.mdand other relevant documentation has been updated with my changes