fix(boilerplate) Fix Icon Type definitions #2915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues at play here: 1. Icon's `style` prop overrides the Wrapped `TouchableOpacity`'s `style` prop with an incompatible `StyleProp<ImageStyle>` 2. Icon changed the wrapper used based on the presence of the `onPress` prop, which made accurate typing and linting difficult. See #2888 (comment) for more information. This commit fixes #2888 by simply separating `Icon` into `PressableIcon` and `Icon` components, with simplified prop types for each, and updates the docs to reflect the change.
silasjmatson
commented
Mar 19, 2025
silasjmatson
commented
Mar 19, 2025
robinheinze
reviewed
Mar 19, 2025
silasjmatson
commented
Mar 20, 2025
Collaborator
|
🎉 This PR is included in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two issues at play here:
styleprop overrides the WrappedTouchableOpacity'sstyleprop with an incompatibleStyleProp<ImageStyle>onPressprop, which made accurate typing and linting difficult.See
#2888 (comment) for more information.
This commit fixes #2888 by simply separating
IconintoPressableIconandIconcomponents, with simplified prop types for each, and updates the docs to reflect the change.Checklist
README.mdand other relevant documentation has been updated with my changes