fix: eslint newline error on model generator #2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(read(`${TEMP_DIR}/app/models/Pizza.ts`)).toMatchInlineSnapshot(` | ||
| "import { Instance, SnapshotIn, SnapshotOut, types } from \\"mobx-state-tree\\" | ||
| import { withSetPropAction } from \\"./helpers/withSetPropAction\\" | ||
| "import { Instance, SnapshotIn, SnapshotOut, types } from \\"mobx-state-tree\\" |
Contributor
Author
There was a problem hiding this comment.
note: I think some of the bigger diffs here come from setting prettierPath: null in order to get Prettier v3 to play nice with Jest. See jestjs/jest#14305 (comment)
| "jsx" | ||
| ] | ||
| ], | ||
| "prettierPath": null |
5 tasks
frankcalise
approved these changes
Mar 7, 2025
Contributor
frankcalise
left a comment
There was a problem hiding this comment.
Thanks for redoing that!
infinitered-circleci
pushed a commit
that referenced
this pull request
Mar 7, 2025
## [10.1.7](v10.1.6...v10.1.7) (2025-03-07) ### Bug Fixes * **cli:** fix missing newlines in model generator ([#2910](#2910) by [@coolsoftwaretyler](https://github.com/coolsoftwaretyler)) ([3d9fe38](3d9fe38))
Collaborator
|
🎉 This PR is included in version 10.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supercedes #2812, just with a fresh
masterbranch since there's been some drift and we had weird CI stuff going on.In Ignite X, the model generator would create files that did not pass Prettier config. See "before" screenshot, which came from
npx ignite-cli generate model Pizzain a fresh Ignite X app.This change primarily fixes the prettier error, as seen in the "after" screenshot, which I got by running:
However, when I attempted to update the Jest snapshots, I ran into this issue from Jest: jestjs/jest#14305, so I included this workaround.
Screenshots (if applicable)
Checklist
README.mdand other relevant documentation has been updated with my changes