这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Mar 24, 2025

Description

Screenshots

Added notes in the prompts

image

If expo-router and/or MST removal, prints a warning instead of prompting Remove demo code

image

Checklist

  • README.md and other relevant documentation has been updated with my changes
  • I have manually tested this, including by generating a new app locally (see docs).

moves it after nav and stat mgmt questions which impact it it's removal
@frankcalise frankcalise marked this pull request as ready for review March 24, 2025 13:12
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamonholmgren
Copy link
Member

I like the improvements

@Waffleophagus
Copy link

This looks fantastic! I think this would’ve completely cleared up my confusion when getting started and hopefully will save others! I definitely think this satisfies my issue I opened. #2916

@frankcalise frankcalise merged commit 96aa5cd into master Mar 26, 2025
3 checks passed
@frankcalise frankcalise deleted the fix/cli-demo-app-rem-warning branch March 26, 2025 15:06
infinitered-circleci pushed a commit that referenced this pull request Mar 26, 2025
# [10.2.0](v10.1.9...v10.2.0) (2025-03-26)

### Bug Fixes

* **cli:** reorder demo app question ([#2917](#2917) by [@frankcalise](https://github.com/frankcalise)) ([96aa5cd](96aa5cd))

### Features

* **boilerplate:** upgrade to react-navigation v7 ([#2908](#2908) by [@frankcalise](https://github.com/frankcalise)) ([0b14fdd](0b14fdd))
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc/CLI suggestion - Expo router removes demo code

7 participants