这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fpena
Copy link
Contributor

@fpena fpena commented Apr 30, 2025

Description

This pull request improves the ListItem component, focusing on enhancing flexibility by dynamically choosing between TouchableOpacity and View based on the presence of touchable props.

Screenshots

Before After
Simulator Screen Recording - iPhone 16 Pro - 2025-04-30 at 18 20 58 Simulator Screen Recording - iPhone 16 Pro - 2025-04-30 at 18 20 23

Checklist

  • README.md and other relevant documentation has been updated with my changes
  • I have manually tested this, including by generating a new app locally (see docs).

@fpena fpena requested review from frankcalise and jamonholmgren May 1, 2025 01:24
@fpena fpena marked this pull request as ready for review May 1, 2025 01:24
@fpena fpena changed the title Fpena/make listitem view if no press props are passed Improve ListItem component to dynamically choose between TouchableOpacity and View based on touchable props May 1, 2025
Copy link
Member

@markrickert markrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Feel free to merge.

@markrickert markrickert changed the title Improve ListItem component to dynamically choose between TouchableOpacity and View based on touchable props feat(ListItem): Improve ListItem component to dynamically choose between TouchableOpacity and View based on touchable props May 12, 2025
@fpena fpena merged commit b25b274 into master May 12, 2025
3 checks passed
@fpena fpena deleted the fpena/make-listitem-view-if-no-press-props-are-passed branch May 12, 2025 18:55
infinitered-circleci pushed a commit that referenced this pull request May 12, 2025
# [10.4.0](v10.3.0...v10.4.0) (2025-05-12)

### Features

* **ListItem:** Improve ListItem component to dynamically choose between TouchableOpacity and View based on touchable props ([#2934](#2934)) ([b25b274](b25b274))
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 10.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jamonholmgren
Copy link
Member

Very nice @fpena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListItem touchable only when onPress props is present

5 participants