这是indexloc提供的服务,不要输入任何密码
Skip to content

feat(boilerplate): e2e support for dev client or standalone builds #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 29, 2025

Conversation

frankcalise
Copy link
Contributor

Description

Improves the maestro e2e workflow for the boilerplate by having flows for both development and preview/production applications.

How it works

Each maestro test flow is meant to prepend the onFlowStart hook (see FavoritePodcast.yaml). This will help handle the Expo dev client launch screen when running in dev with metro or just boot the application normally if it was installed outside of dev. This is currently handled in the package.json script on the test:maestro* commands via their CLI -e, but could be extended to something else by the consumer, such as different bundle IDs, etc.

Login.yaml subflow has clearState and launchApp removed as it will be taken care of by the onFlowStart hook all the time.

What else was added

  • package.json scripts for
    • test:maestro:ci for when the consumer needs to specifiy a different env var
    • eas preview builds for sims
  • -e IS_DEV=true is used for now because we don't provide a set up where we have multiple bundle IDs out of the box but this could be extended or documented further
  • The podcast API url was added to config.prod.ts because when I built the preview build app, the e2e test failed and couldn't find any podcasts to favorite 😆

Screenshots

Dev Preview
image image

Checklist

  • I have manually tested this, including by generating a new app locally (see docs).

Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + pitched in a couple of commits. Thanks for doing this, man! I think it'll be very useful for the community.

@frankcalise frankcalise merged commit a126cc3 into master Apr 29, 2025
3 checks passed
@frankcalise frankcalise deleted the feat/e2e-on-flow-start branch April 29, 2025 17:50
infinitered-circleci pushed a commit that referenced this pull request Apr 29, 2025
# [10.3.0](v10.2.0...v10.3.0) (2025-04-29)

### Bug Fixes

* **boilerplate:** upgrade expo deps ([#2928](#2928) by [@branaust](https://github.com/branaust)) ([d3ecdab](d3ecdab))

### Features

* **boilerplate:** e2e support for dev client or standalone builds ([#2931](#2931) by [@frankcalise](https://github.com/frankcalise) and [@coolsoftwaretyler](https://github.com/coolsoftwaretyler)) ([a126cc3](a126cc3))
@infinitered-circleci
Copy link
Contributor

🎉 This PR is included in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants