-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(boilerplate): e2e support for dev client or standalone builds #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcalise
commented
Apr 23, 2025
frankcalise
commented
Apr 23, 2025
coolsoftwaretyler
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + pitched in a couple of commits. Thanks for doing this, man! I think it'll be very useful for the community.
infinitered-circleci
pushed a commit
that referenced
this pull request
Apr 29, 2025
# [10.3.0](v10.2.0...v10.3.0) (2025-04-29) ### Bug Fixes * **boilerplate:** upgrade expo deps ([#2928](#2928) by [@branaust](https://github.com/branaust)) ([d3ecdab](d3ecdab)) ### Features * **boilerplate:** e2e support for dev client or standalone builds ([#2931](#2931) by [@frankcalise](https://github.com/frankcalise) and [@coolsoftwaretyler](https://github.com/coolsoftwaretyler)) ([a126cc3](a126cc3))
🎉 This PR is included in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the maestro e2e workflow for the boilerplate by having flows for both development and preview/production applications.
How it works
Each maestro test flow is meant to prepend the
onFlowStart
hook (seeFavoritePodcast.yaml
). This will help handle the Expo dev client launch screen when running in dev with metro or just boot the application normally if it was installed outside of dev. This is currently handled in thepackage.json
script on thetest:maestro*
commands via their CLI-e
, but could be extended to something else by the consumer, such as different bundle IDs, etc.Login.yaml
subflow hasclearState
andlaunchApp
removed as it will be taken care of by theonFlowStart
hook all the time.What else was added
test:maestro:ci
for when the consumer needs to specifiy a different env var-e IS_DEV=true
is used for now because we don't provide a set up where we have multiple bundle IDs out of the box but this could be extended or documented furtherconfig.prod.ts
because when I built the preview build app, the e2e test failed and couldn't find any podcasts to favorite 😆Screenshots
Checklist