refactor: replace shell commands with filesystem API in project creation #2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this! We will try and get it tested soon |
joshuayoes
requested changes
Oct 29, 2024
joshuayoes
reviewed
Oct 29, 2024
Contributor
joshuayoes
left a comment
There was a problem hiding this comment.
I was able to reproduce the issue with the Expo Router flow on Windows
joshuayoes
approved these changes
Oct 29, 2024
Contributor
joshuayoes
left a comment
There was a problem hiding this comment.
Gave this a test, the Expo Router workflow works on Windows ✅
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 29, 2024
## [10.0.2](v10.0.1...v10.0.2) (2024-10-29) ### Bug Fixes * **boilerplate:** expo-router keyboard provider + theme fix ([#2825](#2825) by [@frankcalise](https://github.com/frankcalise)) ([f82f324](f82f324)) * **cli:** add --legacy-peer-deps for npm users ([#2823](#2823) by [@frankcalise](https://github.com/frankcalise)) ([e59d880](e59d880)) * **cli:** fix issue with workflow prompt values ([#2821](#2821) by [@frankcalise](https://github.com/frankcalise)) ([f2cdd00](f2cdd00)) * **cli:** replace shell commands with filesystem API ([#2817](#2817) by @AsterisMono) ([fd0a418](fd0a418))
Collaborator
|
🎉 This PR is included in version 10.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
Fixes #2816.
This PR replaces the
rmandmvshell commands in project creation withgluegun (fs-jetpack)filesystem calls to ensure compatibility with Windows (Since there's nomvandrmin Windows CMD).