fix(boilerplate): reworks some mst removal decorators #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jpoliachik
approved these changes
Oct 30, 2024
Contributor
Jpoliachik
left a comment
There was a problem hiding this comment.
Good fix.
Still not a huge fan of how nitpicky the removal decorators can be, but I honestly don't know a better way to be able to support some of the code changes necessary for MST removal.
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 30, 2024
## [10.0.4](v10.0.3...v10.0.4) (2024-10-30) ### Bug Fixes * **boilerplate:** reworks some mst removal decorators ([#2832](#2832) by [@frankcalise](https://github.com/frankcalise)) ([4c8d97a](4c8d97a))
Collaborator
|
🎉 This PR is included in version 10.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
@mstmark up to remove / adjust syntax lines no longer worked. These changes fix that.How to Test
npx ignite-cli@10.0.3 new PizzaLint --overwrite --packager=npm --yes --debug --install-deps false --state none --remove-demoignite/bin/ignite new PizzaLint --overwrite --packager=npm --yes --debug --install-deps false --state none --remove-demowhere the firstignitedirectory is this GitHub project