这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@lindboe
Copy link
Contributor

@lindboe lindboe commented Oct 29, 2024

Disables prop-types rule from eslint-plugin-react recommended config.

I thought this was already disabled since I hadn't seen errors with it, but ran into one today.

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

Screenshots (if applicable)

Before After
[Insert before screenshot/video] [Insert after screenshot/video]

Disables prop-types rule from eslint-plugin-react recommended config.

I thought this was already disabled since I hadn't seen errors with it, but ran into one today.
Copy link
Member

@markrickert markrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! 👍

2.9.5 changed TS definitions to the point that some tests are now
failing. Pin for now to what was working, fix later.
@lindboe lindboe merged commit f3f4596 into master Oct 30, 2024
1 check passed
@lindboe lindboe deleted the lindboe/disable-prop-types-linter branch October 30, 2024 02:35
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants