feat(cli): expo-router option #2727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Member
jamonholmgren
left a comment
There was a problem hiding this comment.
Overall looks very good.
Curious if we should do --mst or if we should do --state=mst, to leave room for potentially figuring out a good way to automatically do different state management systems in the future.
* fix(cli): reworks --mst to --state=mst * refactor(cli): tidy up MST removal
3957b0d to
eee948a
Compare
Contributor
Author
This was reworked in a separate PR (based off of this one) and brought in now |
mazenchami
approved these changes
Aug 13, 2024
Contributor
mazenchami
left a comment
There was a problem hiding this comment.
this is really cool 🎉
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 14, 2024
# [10.0.0](v9.10.1...v10.0.0) (2024-10-14) ### Bug Fixes * **boilerplate:** expo-router initialize i18n ([#2791](#2791) by [@frankcalise](https://github.com/frankcalise)) ([a00113e](a00113e)) * **boilerplate:** Make icon default color explicit, and respond to dark mode ([#2795](#2795) by [@lindboe](https://github.com/lindboe)) ([b82398d](b82398d)) * **cli:** improper MST removal when using CLI prompt, new arch compat ([#2785](#2785) by [@frankcalise](https://github.com/frankcalise)) ([3956652](3956652)) * remove snackify command and references ([#2763](#2763) by [@frankcalise](https://github.com/frankcalise)) ([09671e8](09671e8)) ### Features * Ignite X with Expo 51 ([005ef05](005ef05)) * **boilerplate:** Toggle component refactored to Checkbox, Radio and Switch ([#2667](#2667) by [@frankcalise](https://github.com/frankcalise)) ([54f5208](54f5208)) * **cli:** expo-router option ([#2727](#2727) by [@frankcalise](https://github.com/frankcalise)) ([8bea1f9](8bea1f9)), closes [#2731](#2731) * **cli:** generator options --dir and --case ([#2726](#2726) by [@frankcalise](https://github.com/frankcalise)) ([dff3d24](dff3d24)) * **Theming:** Adds theming support with documentation. ([#2636](#2636)) ([a1ae047](a1ae047)) * **v10:** cng default ([#2641](#2641)) ([c7d998d](c7d998d)) * **v10:** Remove MobX-State-Tree flag for non-demo projects ([#2647](#2647) by @Jpoliachik) ([a738243](a738243)) * add MMKV for v10 ([#2660](#2660) by [@frankcalise](https://github.com/frankcalise)) ([9164e5e](9164e5e)) ### BREAKING CHANGES * Ignite X is out now! This update adds: * Expo Prebuild as default * Dark mode support * Static routing with Expo Router * Flexible generator directory support * Option to remove mobx-state-tree * AsyncStorage->MMKV * New i18n configuration with react-i18next * Lint configuration updates * Toggle component → Checkbox, Radio, and Switch * Improved keyboard avoidance * Component test example configuration Read all about it in our blog article! https://shift.infinite.red/what-is-ignite-x-9ecde0b34d75
Collaborator
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
expo-routervalue to the--experimentalswitchexpo-routerremove-mst-markupcommand to account for./appor./srcas the source directory to clean up--mstflag)--experimental=expo-router