Simplify demo translations #2697
Conversation
frankcalise
left a comment
There was a problem hiding this comment.
Looks good! Think we just need some adjustments for the markup comments
| }, | ||
| }, | ||
| ...demo.ar, | ||
| // @demo remove-block-end |
There was a problem hiding this comment.
These remove-block-end comments were specific to the remove-block-start ones.
This is for when you npx ignite-cli new MyApp --remove-demo the marked areas would have been cleaned up.
🤔 Our test should probably be improved that no @demo remains in any file after --remove-demo has run. I'm thinking this might need some adjustments. With this flag, I think welcomeScreen, errorScreen, and emptyStateComponent are the ones that need to say (perhaps common)
|
after doing some chatting around what we want to actually do here, i'm going to close out this PR and open a new one with updates. thank you @leonskim for taking the initial stab at it |
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR