这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@frankcalise
Copy link
Contributor

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes

Describe your PR

Screenshots

Web

toggle-fix-web

iOS example (and RTL)

toggle-fix-mobile.mp4

Copy link
Member

@markrickert markrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Checked on mobile and web. Looks good! 👍

Copy link
Contributor

@ecroce ecroce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie mille!

@frankcalise frankcalise merged commit c0dcc6d into master Feb 21, 2024
@frankcalise frankcalise deleted the fix/web-toggle branch February 21, 2024 16:57
infinitered-circleci pushed a commit that referenced this pull request Feb 21, 2024
## [9.6.1](v9.6.0...v9.6.1) (2024-02-21)

### Bug Fixes

* **boilerplate:** jest.config.js remove jsdom test env for better RNTL support out of box ([#2632](#2632) by [@frankcalise](https://github.com/frankcalise)) ([22c7afc](22c7afc))
* **boilerplate:** remove `yarn prebuild` script in favor of clean ([#2635](#2635) by [@frankcalise](https://github.com/frankcalise)) ([f669a32](f669a32))
* **boilerplate:** web hmr fixes ([#2646](#2646) by [@frankcalise](https://github.com/frankcalise)) ([45aabb2](45aabb2))
* **cli:** Global Expo CLI checks in Doctor command ([#2618](#2618) by @Dax911) ([d0b2b2d](d0b2b2d))
* **components:** switch animation slide on web ([#2642](#2642) by [@frankcalise](https://github.com/frankcalise)) ([c0dcc6d](c0dcc6d))
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 9.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle "switch" variant does not slide on web

5 participants