这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@morganick
Copy link
Contributor

@morganick morganick commented Jan 5, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • README.md has been updated with your changes, if relevant

Describe your PR

If you have your git diff configured with an external diff tool, the tests will not pass because it relies on the output of the internal git diff command. This updates the command lines arguments for consistency to force git to use the internal diff tool always for the spec. (Docs: https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---no-ext-diff)

@morganick morganick self-assigned this Jan 6, 2024
@morganick morganick force-pushed the fix-stable-git-diff branch from c4dccae to 22b6bf6 Compare January 6, 2024 14:19
@morganick morganick marked this pull request as ready for review January 6, 2024 14:27
@morganick morganick requested a review from frankcalise January 6, 2024 14:28
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@frankcalise frankcalise merged commit 3fec7be into master Jan 6, 2024
@frankcalise frankcalise deleted the fix-stable-git-diff branch January 6, 2024 20:09
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 9.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants