feat(cli): split expo workflow decision tree, use 'cng' instead of 'prebuild' #2607
Conversation
|
up |
1 similar comment
|
up |
|
UP! |
|
I need this! |
|
hi mark |
|
I'm flattered by the suspiciously sudden interest in this |
|
so... where we at with this? |
frankcalise
left a comment
There was a problem hiding this comment.
I think this looks good, nice work!
I'm only questioning if we should change the wording for "Do you want to use Expo" for a couple reasons
One, using Expo means many things (cli, SDK, EAS, etc)
Two, each workflow we're using Expo CLI and SDK here out of the box with Ignite so it seems misleading to ask it if on the DIY option it's not actually undoing those
I'm trying to think of what would read better, though.
|
@frankcalise I see what you mean, how it could be ambiguous to ask "do you want to use Expo" - since we also technically use Expo libraries in DIY flow, and EAS - but IMO I think its suitable enough to help users simply decide "do I want to buy into the whole Expo ecosystem or not". I'm going to go ahead and merge, but I'm happy to revise if we think of something better in the future. |
|
Hmm...why didn't this land? 🤔 |
|
I clicked "re-run from failed" |
|
Regenerated it. Re-running. |
|
Hmm, maybe I need to delete the expired one. Re-running again. |
# [9.4.0](v9.3.1...v9.4.0) (2024-01-15) ### Features * **cli:** add expo decision tree, use 'cng' to replace 'prebuild' ([#2607](#2607) by @Jpoliachik) ([1b40712](1b40712))
|
🎉 This PR is included in version 9.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
ignite-cli new:Do you want to use Expo?cngworkflow type to replaceprebuild, to match Expo's naming. Deprecatedprebuildfor potential future removal.Note: References new Ignite Cookbook recipe from infinitered/ignite-cookbook#116
Screenshots