fix(boilerplate): jest.config.js remove jsdom test env #2632
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L support out of box
markrickert
requested changes
Feb 13, 2024
Member
markrickert
left a comment
There was a problem hiding this comment.
@frankcalise I also just ran into this issue, but to fix it i had to remove the same property from the base package.json as well: https://github.com/infinitered/ignite/blob/master/package.json#L154
Contributor
Author
|
@markrickert that was a result of running |
Member
|
@frankcalise Sorry, false alarm... i'm getting a different error actually: Though it's probably something i did in my branch. |
markrickert
approved these changes
Feb 21, 2024
infinitered-circleci
pushed a commit
that referenced
this pull request
Feb 21, 2024
## [9.6.1](v9.6.0...v9.6.1) (2024-02-21) ### Bug Fixes * **boilerplate:** jest.config.js remove jsdom test env for better RNTL support out of box ([#2632](#2632) by [@frankcalise](https://github.com/frankcalise)) ([22c7afc](22c7afc)) * **boilerplate:** remove `yarn prebuild` script in favor of clean ([#2635](#2635) by [@frankcalise](https://github.com/frankcalise)) ([f669a32](f669a32)) * **boilerplate:** web hmr fixes ([#2646](#2646) by [@frankcalise](https://github.com/frankcalise)) ([45aabb2](45aabb2)) * **cli:** Global Expo CLI checks in Doctor command ([#2618](#2618) by @Dax911) ([d0b2b2d](d0b2b2d)) * **components:** switch animation slide on web ([#2642](#2642) by [@frankcalise](https://github.com/frankcalise)) ([c0dcc6d](c0dcc6d))
Collaborator
|
🎉 This PR is included in version 9.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
jsdomshould only be used for web (which although we support, isn't our main target)