fix (localization): Guard against i18n errors for older Android platforms #2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazenchami
approved these changes
Feb 9, 2024
Contributor
mazenchami
left a comment
There was a problem hiding this comment.
Thanks for putting this together! Much appreciated 🚀 🎉
Collaborator
|
🎉 This PR is included in version 9.4.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
On certain older platforms, the
systemLocalereturned byexpo-localizationmight be invalid, leading to a crash whensystemLocale.languageTagorsystemLocale.textDirectionare referenced. This PR just adds optional chaining for these references and defaults toen-USif there is a problem.Also changed the default locale from
entoen-USto fix an Apple TV issue, but this may have already been dealt with in #2622 .Reviewers: if desired, we could add
console.warn()calls if this condition is encountered, butexpo-localizationis already writing Android logcats if there are errors.