fixes #2596 back button error on web #2597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BackButton` is only on android, so instead of checking if the platform isn't iOS, check that it isn't android
Contributor
Author
|
According to React Native's docs, Therefore, should be equivalent... But it looks like on react native web, This looks like the real type it should be: For the sake of #2596, I still think the solution of this PR is a good change. |
frankcalise
approved these changes
Jan 3, 2024
Contributor
frankcalise
left a comment
There was a problem hiding this comment.
Good looking out! Thanks
Collaborator
|
🎉 This PR is included in version 9.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackButtonis only on android, so instead of checking if the platform isn't iOS, check that it isn't androidPlease verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Fixes #2596