fix(cli): warn macOS users about spaces in path #2550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuayoes
approved these changes
Nov 13, 2023
Contributor
joshuayoes
left a comment
There was a problem hiding this comment.
Didn't know about this constraint, but this looks like a good guard rail
infinitered-circleci
pushed a commit
that referenced
this pull request
Nov 14, 2023
## [8.11.2](v8.11.1...v8.11.2) (2023-11-14) ### Bug Fixes * **cli:** warn macOS users about spaces in path ([#2550](#2550) by [@frankcalise](https://github.com/frankcalise)) ([1ec7e64](1ec7e64))
Collaborator
|
🎉 This PR is included in version 8.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Podfilefile: cannot load such file -- ./scripts/autolinking. #2493Podfileto at least fix Pod install (but the project will still not start on iOS, this needs to be fixed upstream in RN)Screenshots