这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(cli): remove demo markup if keeping demo files #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(cli): remove demo markup if keeping demo files #2556

merged 3 commits into from
Nov 16, 2023

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Nov 16, 2023 •
edited
Loading

Describe your PR

  • @jamonholmgren was looking to remove demo markup automatically if keeping the demo in place
  • turns out remove-demo-markup never removed remove-file comments but now it does :D

@frankcalise frankcalise self-assigned this Nov 16, 2023
@frankcalise frankcalise marked this pull request as ready for review November 16, 2023 18:27
@frankcalise frankcalise merged commit db31dea into feat/rn-72-expo-49 Nov 16, 2023
@frankcalise frankcalise deleted the fix/cli-remove-markup branch November 16, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees

@frankcalise frankcalise

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frankcalise @jamonholmgren