docs: set up ir-docs #2530
Merged
docs: set up ir-docs #2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(cli): update generator for expo only * refactor(boilerplate): App to typescript * chore: simplify w/ expo * chore: reanimated deps, other dep clean up * fix(boilerplate): removed problematic @expo/metro-config to run dev client * chore: updated native dirs as per expo dev client build * chore: updates to latest Expo SDK * test: update app-icon / splash section * fix(cli): rename bridging header and entitlements * chore(boilerplate): dep update * docs(folder-structure): updated for rework * chore: updates due to structure changes, tests passing 🤞 * fix(generators): add new line to end of app.json * chore: update reactotron dev deps * fix(boilerplate): WelcomeScreen needs this import even if demo removed * fix(cli): remove deprecrated expo flag * fix(boilerplate): match babel config more closely to expo default * chore(cli): reactotron deps * feat(cli): prompt for enabling new arch * chore: remove unused log statements * chore: expect TS error for now * chore(boilerplate): RN 0.72.3 --------- Co-authored-by: Joshua Yoes <joshua.r.yoes@gmail.com>
There was a problem with the web implementation because we were directly using `DrawerLayout` from `react-native-gesture-handler`. Moving to `Drawer` from `react-native-drawer-layout` (a react-navigation product) mitigates this issue without losing any functionality.
|
|
||
| ## [Full Documentation](https://github.com/infinitered/ignite/blob/master/docs) | ||
|
|
||
| We've put great effort into the documentation as a team, please [read through it here](https://github.com/infinitered/ignite/blob/master/docs). If you're unsure why a certain decision was made related to this boilerplate or how to proceed with a particular feature, it's likely documented. If it still isn't clear, go through the proper [help channels](#reporting-bugs--getting-help) and we always welcome PRs to improve the docs! |
Contributor
There was a problem hiding this comment.
When ir-docs goes live this will be `https://docs.infinite.red/ignite
914f6e2 to
71ef751
Compare
Member
|
I pushed up a cleanup branch that incorporates some of the changes i'd already made locally while working on this:
|
1 task
Member
|
Got the conflicts resolved. Should be mergeable once @trevor-coleman and @frankcalise are on board. |
Contributor
|
Took a quick look and the changes look good -- one small suggestion is to use larger gaps for the ordering numbers. For instance instead of 1, 2, 3, you can use 100,200,300. That allows for things to be inserted later without having to edit all the files. But I don't think it's not really necessary if there aren't a huge number of things in the list. |
Contributor
|
@frankcalise -- is this still good to go? @jamonholmgren was hoping to get this onto |
Collaborator
|
🎉 This PR is included in version 9.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR
ir-docsstructure for DocusaurusStill Needs
docs/boilerplate-docs/Boilerplate.mddocs/README.mdREADME.mdto remote IR docs site where Ignite documentation will live