(boilerplate): Merge useEffect calls in LoginScreen for clarity #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the contribution, good catch! |
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 3, 2023
## [8.8.5](v8.8.4...v8.8.5) (2023-08-03) ### Bug Fixes * **boilerplate:** relocated "useEffect cleanup" in LoginScreen ([#2486](#2486) by [@gaida](https://github.com/gaida)) ([d76815b](d76815b))
Collaborator
|
🎉 This PR is included in version 8.8.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
The current LoginScreen has two separate useEffect calls: one for form pre-fill and one for cleanup. I found the separation confusing.
In this PR, I've merged these calls to make their relationship clearer. Maybe this change could help future users navigate the boilerplate a little bit easier?
Cheers,