chore: enable eslint react-hook/recommended rule set #2454
Conversation
Enable eslint react-hook/recommended rule set, as recommended in the react dev website: https://react.dev/learn/editor-setup#linting
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable react-hooks/rules-of-hooks */ | |||
There was a problem hiding this comment.
This file has a method that starts with use* and react-hooks/rules-of-hooks is complaining about that.
I'm not sure if this is the best approach here.
joshuayoes
left a comment
There was a problem hiding this comment.
Made some comments to move some of the linting settings, but otherwise looks good so far
| "eslint-plugin-import": "^2.22.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-promise": "^5.1.0", | ||
| "eslint-plugin-react-hooks": "^4.6.0", |
There was a problem hiding this comment.
Can you move this package to boilerplate/package.json instead?
This top level package.json is for the cli, where as the boilerplate folder is for the app content.
| "standard", | ||
| "plugin:react-hooks/recommended" |
There was a problem hiding this comment.
Can you move this package to boilerplate/package.json instead?
This top level package.json is for the cli, where as the boilerplate folder is for the app content.
|
Thanks. I'll close and reopen later because after enabling the the linter failed for the generated app. I'll need some more time to fix that. |
Please verify the following:
yarn testjest tests pass with new tests, if relevantDescribe your PR
Enable eslint react-hook/recommended rule set, as recommended in the react dev website: https://react.dev/learn/editor-setup#linting
Related discussion: #2453