这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@theabhishek2511
Copy link
Contributor

@theabhishek2511 theabhishek2511 commented Jun 5, 2023

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • README.md has been updated with your changes, if relevant

Describe your PR

quoted from #2455

Currently (the screen generator) generates a NativeStackScreenProps<AppStackScreenProps<T>>. This evaluates to NativeStackScreenProps<NativeStackScreenProps<AppStackParamList, T>>, which causes TypeScript to throw all sorts of tantrums no matter what route names I pass.

Looking through in discussions and following #2383, changing the generated ScreenProps interface to AppStackScreenProps<T> fixes the problem.

@theabhishek2511
Copy link
Contributor Author

I'm really not sure why CI failed, and I don't have my usual work pc with me (I had to commit off a backup windows machine). If someone can unscrew my screwup, please do so 🙏

@flexbox
Copy link
Collaborator

flexbox commented Jul 6, 2023

@theabhishek2511
It looks like the linter is not happy

image

what's the output of

yarn test

on your machine?

@frankcalise frankcalise merged commit 68f3380 into infinitered:master Aug 4, 2023
infinitered-circleci pushed a commit that referenced this pull request Aug 4, 2023
## [8.8.6](v8.8.5...v8.8.6) (2023-08-04)

### Bug Fixes

* Remove unnecessary NativeStackScreenProps in screen generator ([#2458](#2458) by [@theabhishek2511](https://github.com/theabhishek2511)) ([68f3380](68f3380))
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 8.8.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@theabhishek2511 theabhishek2511 deleted the fix/screen-generator-screenprops branch August 16, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screen generator template generating the wrong ScreenProps interface

4 participants