Android Only - Navigation Bar Background Color #2434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the colors of the app to set the background color of the software navigation bar buttons for Android.
3 tasks
mazenchami
approved these changes
May 11, 2023
Contributor
mazenchami
left a comment
There was a problem hiding this comment.
🚀 thanks for bringing this over to Ignite too!
frankcalise
approved these changes
May 15, 2023
Collaborator
|
🎉 This PR is included in version 8.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the colors of the app to set the background
color of the software navigation bar buttons for Android.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
On Android, the navigation bar background color can be set to match the background color of the app. This PR uses the background color from
colors.backgroundand uses it as the background color of the navigation bar software buttons.