fix(boilerplate): update Text sizeStyles to use satisfies #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuayoes
approved these changes
May 22, 2023
Contributor
joshuayoes
left a comment
There was a problem hiding this comment.
I've done this a few times on other projects. This also has the nice advantage of upgrading typescript. Looks good!
jamonholmgren
approved these changes
May 22, 2023
infinitered-circleci
pushed a commit
that referenced
this pull request
May 23, 2023
## [8.8.2](v8.8.1...v8.8.2) (2023-05-23) ### Bug Fixes * **boilerplate:** Podfile update for hermes-engine ([#2442](#2442) by [@frankcalise](https://github.com/frankcalise)) ([e118b11](e118b11)) * **boilerplate:** update Text sizeStyles to use satisfies ([#2437](#2437) by [@frankcalise](https://github.com/frankcalise)) ([2e96d78](2e96d78))
Collaborator
|
🎉 This PR is included in version 8.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantDescribe your PR
typescript-eslintandprettierplugins to deal withsatisfiesproperlyImages
Now you get typechecking:
And still typeahead (whicih
as TextStyleoriginally accomplished)