这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(cli): move rename before install deps #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix(cli): move rename before install deps #2306

merged 1 commit into from
Nov 16, 2022

Conversation

@frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Nov 16, 2022 •
edited
Loading

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant

Describe your PR

  • Moves renaming of the react-native application to before dependencies are installed
  • A bug was masked with npx pod-install being run after the rename that helped fix things, so now that we moved it to postInstall, rename must occur first
  • This is only relevant to yarn ios

@frankcalise frankcalise marked this pull request as ready for review November 16, 2022 18:22
mazenchami
mazenchami approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@mazenchami mazenchami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when we looked over it earlier on zoom! 🎉 🚀

joshuayoes
joshuayoes approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@joshuayoes joshuayoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What was the bug with npx pod-install?

@frankcalise
Copy link
Contributor Author

frankcalise commented Nov 16, 2022

@joshuayoes It's not with npx pod-install, basically if you did yarn install, pod install (or npx pod-install) and then ran the rename function, if you just did yarn ios after that, the app won't run.

This was masked before as we had:

  • yarn install
  • pod install
  • rename
  • npx pod install

Now that it is

  • yarn install
  • npx pod install
  • rename

yarn ios didn't like something. It isn't until npx pod-install is run again that yarn ios succeeds.

Not sure if that means we need to look at something in our rename or our basic react-native ios template.

@joshuayoes
Copy link
Contributor

joshuayoes commented Nov 16, 2022

Yeah that probably means that rename is touching something that pod-install modifies. Probably worth investigating at some point but out of scope for this PR

@frankcalise frankcalise merged commit d72b159 into master Nov 16, 2022
@frankcalise frankcalise deleted the fix/cli-rename branch November 16, 2022 19:27
infinitered-circleci pushed a commit that referenced this pull request Nov 16, 2022
@semantic-release-bot
chore(release): 8.3.4 [skip ci]
c655358 
## [8.3.4](v8.3.3...v8.3.4) (2022-11-16)

### Bug Fixes

* **cli:** move rename before install deps to fix run-ios ([#2306](#2306)) ([d72b159](d72b159))
@infinitered-circleci
Copy link
Collaborator

infinitered-circleci commented Nov 16, 2022

🎉 This PR is included in version 8.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazenchami mazenchami mazenchami approved these changes

@joshuayoes joshuayoes joshuayoes approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frankcalise @joshuayoes @infinitered-circleci @mazenchami