recipe: update vision camera to use hooks #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecroce
commented
Nov 20, 2024
| - State Management | ||
| last_update: | ||
| author: Justin Poliachik | ||
| author: Ellie Croce |
Contributor
Author
There was a problem hiding this comment.
Forgot to update in last PR
frankcalise
approved these changes
Jan 8, 2025
Contributor
frankcalise
left a comment
There was a problem hiding this comment.
looks good, thanks! sorry I missed this hanging out there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking into #136 and while the issue mentioned doesn't appear to be reproducible, there are a few areas of the recipe that were throwing/out of date. Moved to using the hooks API from react-native-vision-camera in lieu of the imperative API which we were already doing for the barcode scanning.
Sources:
https://react-native-vision-camera.com/docs/guides#gettingrequesting-permissions
https://react-native-vision-camera.com/docs/guides/code-scanning
Open Source License Notice for Contributors
If you are contributing a recipe to this repository, you agree to license your contribution under the terms of the CC BY-SA 4.0 license.
If you have any questions, please reference the CONTRIBUTING.md or LICENSE.md file for more information.
Thank you for your contribution!