This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Bump react native to 0.61.5; bump package versions; fix tests #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update storybook's asyncStorage configuration to fix warning - lint test & storybook stuff too - fix lint complaints - remove `.only` to reenable other tests, then fix them
jamonholmgren
approved these changes
Mar 19, 2020
Member
|
"Someone" 🤣 |
infinitered-circleci
pushed a commit
that referenced
this pull request
Mar 19, 2020
## [4.14.3](v4.14.2...v4.14.3) (2020-03-19) ### Bug Fixes * **deps:** Bump react native to 0.61.5; bump package versions; fix tests ([#325](#325) by [@bryanstearns](https://github.com/bryanstearns)) ([a229788](a229788))
Collaborator
|
🎉 This PR is included in version 4.14.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped nearly all outdated dependencies (left the few tied to e.g. react/RN version); this required only a couple of code changes, like Storybook's asyncStorage configuration.
Also, since I noticed a squiggle in my editor that
yarn lintdidn't complain about, I addedtest&storybookdirectories to eslint's list, and fixed the complaints that produced.Also also, someone left a
.onlyon one of the generators-integration tests, so we weren't running any of the other tests in that file. When I removed it, I found they were broken by the recentIGNITE_COMMANDchange, and fixed 'em.