This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Fix format globs; bump Typescript to 3.8 #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late) We weren't actually reformatting a lot of our source files!
robinheinze
approved these changes
Mar 17, 2020
jamonholmgren
approved these changes
Mar 17, 2020
infinitered-circleci
pushed a commit
that referenced
this pull request
Mar 17, 2020
## [4.14.2](v4.14.1...v4.14.2) (2020-03-17) ### Bug Fixes * **lint:** format globs; bump Typescript to 3.8 ([#324](#324) by [@bryanstearns](https://github.com/bryanstearns)) ([3a343bb](3a343bb))
Collaborator
|
🎉 This PR is included in version 4.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated a new app with 4.14.1 and found that
ignite g screenleftapp/screens/index.tswith a syntax error:ignite newproduced that file without a trailing newline.I tracked this down to incorrect globs in package.json's
formatscripts - they weren't quoted, so the shell was expanding them incorrectly, and a lot of files were left unprettiered.This PR fixes the globs, and includes changes resulting from prettiering everything. I made sure the tests pass (which format and lint a generated project) - that made me notice that we weren't cleaning up the generated project, so I fixed that.
Also, I discovered weird errors from eslint; I fixed them by bumping our @typescript-eslint versions, but that got me an incompatibility with typescript 3.7, so I bumped that to 3.8.3 (top-level
awaitftw!)