This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Fix/upgrade linting #298
Merged
Fix/upgrade linting #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests too Also: - for now, don't --fix when linting; will add it back for devs (but not CI) later - clean up tsconfig.json's include/exclude lists
… corresponding tests
…ix new complaints - don't ban @ts-ignore - use comments on two intentially-empty functions - add index.js to tsconfig.json
jamonholmgren
approved these changes
Dec 17, 2019
infinitered-circleci
pushed a commit
that referenced
this pull request
Dec 17, 2019
## [4.11.4](v4.11.3...v4.11.4) (2019-12-17) ### Bug Fixes * **linting:** Fixes linting of newly generated apps ([#298](#298) by [@bryanstearns](https://github.com/bryanstearns)) ([a8e40d8](a8e40d8))
Collaborator
|
🎉 This PR is included in version 4.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting to work on finishing #275, I noticed that
yarn lintfor the Bowser project itself (that is, not the generated app) was really linting the compiled javascript instead of the original typescript.Fixing that got me a complaint that the typescript-eslint parser & plugin weren't compatible with my version of Typescript (which always seems to be "latest" because we don't commit our yarn.lock, and because of yarn hoisting... I think).
So I upgraded them, and fixed a few new complaints they produced. I also upgraded them in the generated apps, and fixed new (but different!) complaints there.
Running the tests (in the outer project) will now also lint (with
--fix), just to help keep things linty-fresh. (CI will also lint, but without--fix.)