This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Re-enable react-native-screens with createNativeStackNavigator #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinitered-circleci
pushed a commit
that referenced
this pull request
Nov 4, 2019
# [4.11.0](v4.10.1...v4.11.0) (2019-11-04) ### Features * **navigation:** Switch to createNativeStackNavigator ([#289](#289) by [@sballew](https://github.com/sballew)) ([c583ea6](c583ea6))
Collaborator
|
🎉 This PR is included in version 4.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue observed in #285 by using
createNativeStackNavigatorwithin theprimary-navigator.ts.In the future, react-navigation will contain the
createNativeStackNavigatorand we should switch to use that. Details on that are in the@nextdocs: https://reactnavigation.org/docs/en/next/native-stack-navigator.htmlI did not update the navigator generator, but I want feedback on whether or not we think that should be updated.
This PR also contains a small fix that had the linter failing.