This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Remove Storybook & Reactotron from production bundle for performance reasons #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinheinze
approved these changes
Oct 31, 2019
harrisrobin
approved these changes
Oct 31, 2019
Member
Author
|
@harrisrobin I ran this before and after the change: ... and it showed me this: |
infinitered-circleci
pushed a commit
that referenced
this pull request
Nov 3, 2019
# [4.10.0](v4.9.0...v4.10.0) (2019-11-03) ### Bug Fixes * **nav:** Disable react-native-screens for now ([#286](#286) by [@jamonholmgren](https://github.com/jamonholmgren)) ([1c5785e](1c5785e)) * **perf:** Remove Storybook & Reactotron from production bundle ([#287](#287) by [@jamonholmgren](https://github.com/jamonholmgren)) ([539793b](539793b)) ### Features * **boilerplate:** Use barrel exports for screens and components ([#282](#282) by [@robinheinze](https://github.com/robinheinze)) ([93f58f8](93f58f8)) * **tests:** Add test for missing i18n keys ([#278](#278) by [@robinheinze](https://github.com/robinheinze)) ([d0cae54](d0cae54))
Collaborator
|
🎉 This PR is included in version 4.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 400kb from production bundle. 😳