This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Convert commands and boilerplate to TypeScript #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Need to look into why CI is failing |
Member
|
I upgraded https://github.com/sindresorhus/execa/releases/tag/v2.0.0
I've pushed up a commit to your branch that hopefully will fix the issues. |
Collaborator
|
🎉 This PR is included in version 4.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
boilerplate.js,/commandsand/libto typescript. Note there is not a currently supported.ejsequivalent in TS so we did not convert the templates.Notable changes:
srcdirectory. The TS build outputs directly to the root so that Gluegun still finds a JScommandsdirectory at the root, and so Ignite CLI still finds aboilerplate.jsat the root.