这是indexloc提供的服务，不要输入任何密码
Skip to content

[#4] Add Authority.Ecto.HMAC, put_token/2 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

[#4] Add Authority.Ecto.HMAC, put_token/2 #9

merged 1 commit into from
Jan 18, 2018

Conversation

@danielberkompas
Copy link
Contributor

@danielberkompas danielberkompas commented Jan 18, 2018

Closes #4. @rzane any feedback is welcome.

rzane
rzane approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@rzane rzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lib/authority_ecto/changeset.ex
...> changeset = put_token_expiration(changeset, :expires_at, :purpose, recovery: {24, :hours})
...> expires_at = get_change(changeset, :expires_at)
...> expires_at.__struct__
DateTime
Copy link
Contributor

@rzane rzane Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better docs 👍

@danielberkompas danielberkompas merged commit a8cc419 into master Jan 18, 2018
@danielberkompas danielberkompas deleted the 4-hmac-security branch January 18, 2018 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rzane rzane rzane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielberkompas @rzane