Implement put_encrypted_password/3 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70ec68a to
e17e6ad
Compare
danielberkompas
suggested changes
Jan 17, 2018
Contributor
danielberkompas
left a comment
There was a problem hiding this comment.
Looks like there are some conflicts to resolve now that I merged #8. I had one other comment, but overall this looks good!
lib/authority_ecto/changeset.ex
Outdated
| """ | ||
| def put_encrypted_password(changeset, source, destination, algorithm \\ :bcrypt) do | ||
| password = get_change(changeset, source) | ||
| confirmation = String.to_atom(Atom.to_string(source) <> "_confirmation") |
Contributor
There was a problem hiding this comment.
A more secure version of this would be:
confirmation = String.to_existing_atom("#{source}_confirmation")String.to_atom is less safe than String.to_existing_atom, because it creates new atoms. If user input ever gets passed into String.to_atom, the code will have a denial-of-service vulnerability. Atoms aren't garbage collected, so if a user can create atoms, they can crash the server.
For this reason, it's probably safer to just never use String.to_atom.
e17e6ad to
92cdc25
Compare
danielberkompas
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2.