Authority.Ecto.Enum #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielberkompas
approved these changes
May 16, 2018
Contributor
|
Looks good to me. We can add docs before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By providing
Authority.Ecto.Enum, things get a bit simpler.Now, we no longer need
exnumeratorfor tests.More importantly, people won't have to have that boilerplate in their codebase. We don't need to generate tests for the
Lock.ReasonorToken.Purpose(because you'd be testing the library).And now, because the submodules get so simple, we can just inline them in the parent module, which means the generator doesn't have to resolve paths for submodules. Overall, I think this change reduces complexity for both maintainers and end-users.
This still needs docs, though.