Require confirmation only if password changed #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e99c8d to
dbe32c7
Compare
Currently, `validate_secure_password/1` will raise an error if you try to change any field on your `User` without specifying `password_confirmation`. This commit makes it so that the `confirmation` field will only be required if you try to change the designated password field.
dbe32c7 to
ffe9a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
validate_secure_password/1will raise an error if you tryto change any field on your
Userwithout specifyingpassword_confirmation.This commit makes it so that the
confirmationfield will only be required if you try to change the designated password field.