这是indexloc提供的服务，不要输入任何密码
Skip to content

The token deletion in update_user seems a little overzealous #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

The token deletion in update_user seems a little overzealous #12

wants to merge 1 commit into from

Conversation

@rzane
Copy link

@rzane rzane commented Jan 17, 2018 •
edited
Loading

After using a recovery token and updating the user's password, Authority should delete the all recovery tokens for the user. However, Authority is actually deleting all recovery tokens for ALL users.

It's basically running this query:

DELETE tokens AS t0
WHERE ((t0.user_id = 1) AND (t0.id != 32))
OR (t0.purpose = "recovery")

@danielberkompas
Copy link
Contributor

danielberkompas commented Jan 17, 2018

Good bug report! Probably an issue with an or_where call somewhere in the template. Will look into it when I can.

@danielberkompas
Copy link
Contributor

danielberkompas commented Jan 19, 2018

Closing this because Template was moved to authority_ecto. Will address this issue over there.

@danielberkompas danielberkompas mentioned this pull request Jan 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rzane @danielberkompas