Ensure launched is false when a background notification is received
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `on_push_notification` method sets `launched` to true if the user has received a background push notification. 1. When the push arrives with the app in the background, the state is `UIApplicationStateBackground` 2. If you open it from a push notification, the state is `UIApplicationStateInactive` 3. If it arrives while the app is in the foreground, the state is `UIApplicationStateActive` Therefore we only want launched to be true for `UIApplicationStateInactive`.
Member
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
on_push_notificationmethod setslaunchedto true if the user has received a background push notification.UIApplicationStateBackgroundUIApplicationStateInactiveUIApplicationStateActiveTherefore we only want launched to be true for
UIApplicationStateInactive.