Fix file dependencies issue while working with 'motion-yapper' gem #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th gem that set detect_dependencies to false
Member
|
@nanamiwang Thanks for contributing! This looks like an edge case to me, so rather than changing how the gem works, I think we'll just document your work-around so any other people that run into this issue will find this solution. However, it's @jamonholmgren's decision to make. |
Member
|
Actually, this is @macfanatic and @ryanlntn's baby now. :) |
Member
|
@kevinvangelder Unfortunately it's not all that uncommon for other gems to turn off dependency detection. That's why ProMotion started specifying the file dependencies in the Rakefile. Given that and the fact that ProMotion already does this, I'm for it. Unless @macfanatic and/or @jamonholmgren have any objections. |
Member
|
👍 There's no downside to this. |
ryanlntn
added a commit
that referenced
this pull request
Feb 6, 2015
Fix file dependencies issue while working with 'motion-yapper' gem
Member
|
Great! Thanks @nanamiwang ! |
Contributor
Author
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemfile
Run rake, then an exception occurred:
The root cause is ProMotion-menu depends on RM auto file dependency detection, but 'motion-yapper' turn off this feature by setting detect_dependencies to false. motion-yapper did this because old version of motion-support is incompatible with auto file dependency detection.
Learning from ProMotion, this issue can be avoided by specify all file dependencies in Rakefile.
jamonholmgren/ProMotion#555