Add ability to set maximum drawer width #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/ProMotion/menu/visibility.rb
Outdated
Contributor
There was a problem hiding this comment.
Instead of implementing this, could we alias?
alias_method :max_left_width, :maximumLeftDrawerWidth
alias_method :max_left_width=, : setMaximumLeftDrawerWidth
Member
There was a problem hiding this comment.
I'd be cool with that. RubyMotion automatically aliases setX methods to x=, so you could do:
alias_method :max_left_width, :maximumLeftDrawerWidth
alias_method :max_left_width=, :maximumLeftDrawerWidth=
Contributor
There was a problem hiding this comment.
That's true, so I'm fine with either syntax.
Contributor
|
I'd vote to rebase this into 1 commit, and then I'd love to merge it in. |
Update README Switch to alias and move to Drawer Move back into Visibility using class_eval
ba4923c to
fa4dd56
Compare
Member
Author
|
Rebased! |
macfanatic
added a commit
that referenced
this pull request
Aug 31, 2014
Add ability to set maximum drawer width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.