Adds the ability to include the user pin in the zoom_to_fit_annotations method #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jamonholmgren if you want to take a look and merge, i'll release a new gem version. |
Member
There was a problem hiding this comment.
I tend to like option hashes (you've probably noticed) since they self-document on the app side.
zoom_to_fit_annotations(true, true)
# vs
zoom_to_fit_annotations(true, include_user: true)
# or even better (but this breaks the API):
zoom_to_fit_annotations(animated: true, include_user: true)
Member
|
Otherwise looks good! Any way to test this? I know map tests are a royal pain. |
Member
Author
|
Updated to take a hash as requested... also preserves backwards compatibility so that if a user passes |
Member
Author
|
Tests are a PITA, and I'm not sure there's any way to test easily. I've done integration tests on all possible parameter combinations and it works as expected. |
jamonholmgren
added a commit
that referenced
this pull request
Nov 17, 2014
Adds the ability to include the user pin in the zoom_to_fit_annotations method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice for zooming into all annotations PLUS the user to fit the screen.
This should always be called after you know you have a user location on the screen, most likely inside the
on_user_location(location)method. Otherwise, it ignores the user's location since it's stillnil.