feat(elasticsearch): add configurable timeout and retry mechanisms #8770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add per-API timeout configuration with fallback to hardcoded defaults - Add per-API retry attempts configuration with global fallback - Support APIs: exists, get, search, bulk, update, delete_by_query, sql, health - Maintain backward compatibility with previous hardcoded values as defaults - Optimize code structure with extracted _init_config method and constants - Update configuration documentation and Docker templates Breaking changes: None (fully backward compatible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, the retry attempts and timeout values for Elasticsearch (ES) requests are not configurable, and some APIs—such as exists—use an unreasonable default timeout of 600 seconds.
In the current implementation, the number of retries and the timeout duration for ES requests are hardcoded and cannot be adjusted through configuration. This means that all API operations, regardless of their nature, use the same default values. For example, the exists API, which is typically a quick check, also uses the default 600-second timeout. This is not appropriate, as such a long timeout is excessive for simple existence checks and can lead to inefficient resource usage and delayed error handling.
Making these parameters configurable allows for more fine-grained control, so each API can have retry and timeout settings that match its expected behavior and performance requirements.
Type of change