-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Feat:Add a way to preview office file #8598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huang-aoqin
wants to merge
7
commits into
infiniflow:main
Choose a base branch
from
tecpie:feature_office_preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 将 convert_to_pdf函数的输入参数从文件路径改为字节流,提高灵活性和兼容性 - 优化 PDF转换过程,使用临时文件替代临时目录 - 更新 task_executor.py 中的 convert2pdf 任务处理逻辑 - 通过这些改动,提高了代码的可维护性和性能
Thank you, pls fix the static check error reported by CI |
-Modify the convert_to-pdf function to return the content of the PDF file instead of the file path -Directly process PDF conversion results in File2DDocumentService, reducing the creation and deletion of temporary files -Optimize exception handling to improve code robustness
fixed |
-Remove the LD_LIBRRY-PATH environment variable setting from Dockerfile -set the LD_LIBRRY-PATH environment variable in the convert_to-pdf function
The original requirement specified frontend preview capability, but your commit only addresses backend implementations. |
Sorry,I'm not good at frontend,The only thing frontend need to do is use /preview interface |
- 将下载附件的名称从 doc[0].name 更改为 doc_location -确保用户下载的合同文件具有正确的名称
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
To solve #7696 , While parse document,allowed read ‘parser_config‘.'pdf_converter' field,if it's true,convert file to pdf.
Then add new preview interface for frontend use to preview office file.
Type of change