Use TextEditor in observations identify #2727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6993ca6.
kueda
requested changes
Jul 14, 2020
app/webpack/observations/identify/components/observation_modal.jsx
Outdated
Show resolved
Hide resolved
Oh good catch. Just saw the change you made to |
kueda
approved these changes
Jul 16, 2020
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2723
It looks like the olderINatTextAreasupported the "mentions" boolean, but it didn't appear to be utilized inCommentFormorIdentificationForm.I was thinking it would be neat to bring in the whole side-by-side comment/id container from observations show, but it might be too much of a change in the UI too quickly. Additionally, it would add a non-trivial amount of work with redux and refactoring to make it work both in observations/show and /observations/identify (observations modal).
From a UI side, I just kinda kept the overall style of the /observations/identify page, but do note the preview functionality (bg-color is different from /observations/show, but consistent for the page).