这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Suleman-Hassan
Copy link
Contributor

Increase the number of variants in 'getXProductsAfterCursorWithinCollectionQuery'

Includes :

- Increase the number of product varianst in  
`getXProductsAfterCursorWithinCollectionQuery`
Includes :

- Increased the number version
@imsujan276
Copy link
Owner

Hi @Suleman-Hassan

thank you for creating the PR.

Could you add in more info in why increase the variant count to max. I guess most stores does not have that many product variant.

Also, when updating any product-related query, please so try to update all the product-related queries like get_n_products.dart, get_products.dart etc. to make sure all the product object works the same

@Suleman-Hassan
Copy link
Contributor Author

Hi @imsujan276

Thank you for your feedback on the PR.

The decision to increase the variant count was made to accommodate the specific needs of the store we're working on. While it's true that many stores might not utilize that many product variants, this particular store deals with a wide range of products that often have numerous variants. By allowing for a higher variant count, we ensure that our system can effectively manage the diverse range of products offered by this store without limitations.

@imsujan276 imsujan276 merged commit 96e12f2 into imsujan276:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants