这是indexloc提供的服务,不要输入任何密码
Skip to content

refactor fromGraphJson methods #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamed-rezaee
Copy link
Contributor

@hamed-rezaee hamed-rezaee commented Apr 23, 2024

  • refactor fromGraphJson methods
  • add flutter-plugins to git ignore

- refactor fromGraphJson methods
- update dependencies
- add flutter-plugins to git ignore
@imsujan276
Copy link
Owner

imsujan276 commented Apr 23, 2024

Hi @hamed-rezaee

Thank you for refactoring the code. I think the updated url_launcher version is not compatible with the supported SDK as you can see in the Analyzer in the Checks tab above

If you are to update the version of the package, please make sure it works for different SDK versions

@hamed-rezaee
Copy link
Contributor Author

Hi @hamed-rezaee

Thank you for refactoring the code. I think the updated url_launcher version is not compatible with the supported SDK as you can see in the Analyzer in the Checks tab above

If you are to update the version of the package, please make sure it works for different SDK versions

hey @imsujan276
it is strange, it doesn't complain on my machine, I tested it with my projects, and all functionalities work as expected.
I will revert the dependency upgrade.

@imsujan276 imsujan276 merged commit 3dce83b into imsujan276:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants